Add test to check if typedefs are being unnecessarily resolved #124
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vgvassilev
force-pushed
the
typedef-to-private
branch
from
0fc3cc8 to
f01e984
Compare
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| }; | ||
| )"); | ||
|
|
||
| clang::NamedDecl *ClassTDT = (clang::NamedDecl*) Cpp::GetNamed("TDT"); |
There was a problem hiding this comment.
warning: use auto when initializing with a cast to avoid duplicating the type name [modernize-use-auto]
Suggested change
| clang::NamedDecl *ClassTDT = (clang::NamedDecl*) Cpp::GetNamed("TDT"); | |
| auto *ClassTDT = (clang::NamedDecl*) Cpp::GetNamed("TDT"); |
|
|
||
| clang::NamedDecl *ClassTDT = (clang::NamedDecl*) Cpp::GetNamed("TDT"); | ||
| auto *CtorTDT = | ||
| (clang::CXXConstructorDecl*) Cpp::GetDefaultConstructor(ClassTDT); |
There was a problem hiding this comment.
warning: do not use C-style cast to convert between unrelated types [cppcoreguidelines-pro-type-cstyle-cast]
(clang::CXXConstructorDecl*) Cpp::GetDefaultConstructor(ClassTDT);
^| void* objectTDT = nullptr; | ||
| FCI_CtorTDT.Invoke((void*)&objectTDT); | ||
| EXPECT_TRUE(objectTDT != nullptr); | ||
| clang::NamedDecl *TDT_f = (clang::NamedDecl*) Cpp::GetNamed("f", ClassTDT); |
There was a problem hiding this comment.
warning: use auto when initializing with a cast to avoid duplicating the type name [modernize-use-auto]
Suggested change
| clang::NamedDecl *TDT_f = (clang::NamedDecl*) Cpp::GetNamed("f", ClassTDT); | |
| auto *TDT_f = (clang::NamedDecl*) Cpp::GetNamed("f", ClassTDT); |
|
This PR is stale because it has been open for 90 days with no activity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same as #97